Hi Rob, if it's just the switch section of the pot that's duff, keep the temporary fix, from your pic it doesn't seem unsafe, then wait 'till another similar constructed switched pot comes along, there is normaly plenty of that type that show up, then just change over the switch body, used to do it all the time, thus keeping it's original appearance, which if possible is what restoration is all about. I had one on an old Hallicrafters, the switched had jammed up, by prising outwardsthe three retaining lugs I was able to remove the switch body, degrease and regrease and reassemble to the pot body. I do not see that there is anything unsafe with what you have done, infact by direct soldering you have eliminated a possible point of arcing.
Lawrence.
Lawrence.
